Standardize Evaluation ID generation #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atetime for testing purposes, consider server timezone (rather than utc in order to reduce cognitive time computation), and apply the timezone to the end of the of the generated string as suggested.
christophertubbs
added
enhancement
|
The suggestions from the comments have been addressed. What needs to be further addressed is to what degree these ids need to be standardized and what all that means. Right now they are just identifiers so that User A can track what they ran and be able to describe its difference from what User B might be doing. The function in question just provides a default (currently just "manual_evaluation_at_{date}"). Using the current logic, "Evaluate HUC01" or "POD and FAR for Sugar Creek 10-19-2020" are just as valid. |
aaraney
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #215
Stems from a comment in a PR about how example generated ids are created when rendering the editing screen for evaluations.